refactor: Link landscapes directly to shared files, links and visualizations #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulschreiber
approved these changes
Oct 18, 2023
| @@ -256,4 +256,12 @@ test('LandscapeSharedDataVisualization: Display visualization', async () => { | |||
| expect(domElement.querySelector('p').textContent).toEqual( | |||
| 'Custom Label: val11' | |||
| ); | |||
|
|
|||
| // Validate fetch input | |||
There was a problem hiding this comment.
suggestion: please better describe what is being validated and hwo.
paulschreiber
requested review from
david-code
and removed request for
david-code
josebui
force-pushed
the
refactor/landscapes-shared-files
branch
from
7f1cb6f to
ab04259
Compare
josebui
force-pushed
the
refactor/landscapes-shared-files
branch
from
69add04 to
c71bc71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issues
Fixes #1228
Related PRs